Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search: Fix fatal error in dev mode, and add a message #10812

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Search: Fix fatal error in dev mode, and add a message #10812

merged 1 commit into from
Dec 5, 2018

Conversation

gibrown
Copy link
Member

@gibrown gibrown commented Dec 4, 2018 •
edited
Loading

Fixes #10632

Also adds a simple message in dev mode to indicate that Jetpack Search is not supported.

See issue for instructions.

Proposed changelog entry

  • Fixes fatal error when Jetpack Search Widget is enabled while site is in Development Mode.

@gibrown gibrown added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Search For all things related to Search labels Dec 4, 2018
@gibrown gibrown requested a review from a team December 4, 2018 18:25
@matticbot
Copy link
Contributor

D21792-code. (newly created revision)

@jetpackbot
Copy link

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review
⚠️ "Testing instructions" are missing for this PR. Please add some
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is automated check which relies on PULL_REQUEST_TEMPLATE.We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS

@gibrown gibrown added the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Dec 4, 2018
dereksmart
dereksmart approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gibrown mind approving/merging D21792-code?

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Dec 4, 2018
jeherve
jeherve approved these changes Dec 5, 2018
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Merging.

@jeherve jeherve merged commit e6fe5a1 into master Dec 5, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 5, 2018
@jeherve jeherve deleted the fix/10632-search-dev-mode branch December 5, 2018 09:49
jeherve added a commit that referenced this pull request Dec 19, 2018
@jeherve
Chanegelog: add #10812
014c1e7
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Chanegelog: add #10812
40945e2
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Jetpack 6.9: Changelog and testing list (#10722)
8d91603 
* Add first version of the Changelog and testing list for 6.9

* Changelog: add #10710

* changelog: add #10538

* changelog: add #10741

* changelog: add #10749

* changelog: add #10664

* changelog: add #10224

* changelog: add #10788

* Changelog: add #10560

* Chanegelog: add #10812

* changelog: add #10556

* Changelog: add #10668

* Changelog: add #10846

* Changelog: add #10947

* Changelog: add #10962

* Changelog: add #10956

* Changelog: add #10940

* Changelog: add #10934

* Changelog: add #10912

* changelog: add #10866

* changelog: add #10924

* Changelog: add #10936

* Changelog: add #10833

* changelog: add #10867

* Changelog: add #10960

* Changelog: add #10888

* changelog: add #10840

* changelog: add #10972

* Changelog: add #10979

* changelog: add #10909

* Changelog: add #10958

* Changelog: add #10981

* Changelog: add #10564

* Changelog: add #10809

* Changelog: add #10982

* Changelog: add #10706

* Changelog: add #10978

* Changelog: add #10132

* Changelog: add #11022

* Changelog: add #11024

* Changelog: add #10875

* Changelog: add #11030

* Changelog: add #11053

* Changelog: add #10880

* Changelog: add #9359

* Changelog: add #11037

* Update block list

* Changelog: add #11060

* Changelog: add #10755

* changelog: add #11000

* Changelog: add #10786

* Changelog: add #10945

* Changelog: add #10597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@dereksmart dereksmart dereksmart approved these changes

Assignees
No one assigned
Labels
[Feature] Search For all things related to Search Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gibrown @matticbot @jetpackbot @jeherve @dereksmart