Asset CDN: Fix json translation loading

[akirk]

When the static asset CDN of Jetpack is loaded, the translations for Gutenberg don'tt load properly because the filename is generated for a wrong path.

Also fixes Automattic/wp-calypso#29309

This has been extensively discussed in https://core.trac.wordpress.org/ticket/45528

Changes proposed in this Pull Request:

• This implements the filter that has been introduced into Core.

Testing instructions:

Prequisit: WordPress 5.0.2(alpha) or trunk

1. Set your WordPress to another language than English.
2. Activate Jetpack Static Asset CDN.
3. Potentially add a filter to your WordPress if it's running trunk (see Create plugin support for CDN'ing of static assets. #10102)
4. Create a new post to open Gutenberg and observe broken translations.
5. Activate the patch: Translations should now load after a reload.

Proposed changelog entry for your changes:

• Fixes loading of the Block Editor UI translations when Static Asset CDN is used (requires WordPress 5.0.2)

[jetpackbot]

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 10, 2019.
Scheduled code freeze: January 3, 2019

Generated by 🚫 dangerJS against ce2839f

[jeherve]

I am not quite sure how to test this. When running a development version of WordPress, the Asset CDN is not applied because that version of WP is not available in a tag. I can use the jetpack_cdn_core_version_and_locale filter to fake a stable release, like so:

add_filter( 'jetpack_cdn_core_version_and_locale', function( $values ) {
	return array( '5.0.1', 'fr_FR' );
} );

But if I do so, the editor does not load at all for me because I am trying to load the block editor from the Alpha version of WP with some outdated JS from the 5.0.1 version of WP.

How did you manage to test this? Am I missing something here?

[akirk]

Hm, at the time when I tested this, the 5.0.1 cdn version was compatible. I guess this means that it's now only possible to test this with a 5.0.1 install and not an alpha.

[jeherve]

👍 So I should have a 5.0.1 + manually apply the patch in https://core.trac.wordpress.org/changeset/44209 ?

[akirk]

Yes, exactly!

[akirk]

@jeherve I updated the patch, the filter was missing two parameters which caused a fatal. Maybe that broke Gutenberg for you? I just tried with a trunk WordPress and

add_filter( 'jetpack_cdn_core_version_and_locale', function( $values ) {
	return array( '5.0.1', 'de_DE' );
} );

and it loads up fine for me.

[jeherve]

It works well for me. There is just a tiny indenting issue!

[jeherve]

Spacing is odd here, I think there may be spaces instead of tabs.

[zinigor]

@jeherve the indentation should be fixed now, thanks for testing!

[jeherve]

Working well. Merging.