forked from sonic-net/sonic-buildimage
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox] Add new thermal sensors for SN5600 #156
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update sonic-swss-common submodule pointer to include the following: * abda263 Make the loglevel persistent by moving the LOGGER table from the LOGLEVEL DB to the CONFIG DB ([sonic-net#687](sonic-net/sonic-swss-common#687)) Signed-off-by: dprital <drorp@nvidia.com>
Update sonic-utilities submodule pointer to include the following: 4a3d49d Fix exception in adding mirror_session when gre_type is absent (sonic-net#2458) 7e7d05c Update the DBmigrator to support persistent loglevel during warm-upgrade (sonic-net#2370) c2841b8 [doc]: Update Command-Reference.md (sonic-net#2444) 254cafc Event Counters CLI (sonic-net#2449) 2dab0d0 [techsupport] Adding FRR EVPN dumps (sonic-net#2442) 3c0aece [show][muxcable] add support for show mux firmware version all (sonic-net#2441) Signed-off-by: dprital <drorp@nvidia.com>
…et#12067) - Why I did it Add the ability to the user to save the loglevel and make it persistent to reboot. - How I did it Move the logger tables from the LOGLEVEL DB to the CONFIG DB. Add new yang model to verify the new config schema. - How to verify it 1. change the orchagent loglevel (for example) -> swssloglevel -c orchagent -l DEBUG 2. save the loglevel -> run config save 3. reboot 4. verify that the orchagent log level is still DEBUG ->run run redis-cli -n 4 hgetall "LOGGER|orchagent"
Signed-off-by: zitingguo-ms <zitingguo@microsoft.com> Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
…bprocess with shell=True (sonic-net#12533) Signed-off-by: maipbui <maibui@microsoft.com> #### Why I did it `subprocess` is used with `shell=True`, which is very dangerous for shell injection. `os` - not secure against maliciously constructed input and dangerous if used to evaluate dynamic content `yaml.load` can create arbitrary Python objects #### How I did it Replace `os` by `subprocess`, remove `shell=True` Use `yaml.safe_load()` #### How to verify it Pass UT
…#12537) Signed-off-by: maipbui <maibui@microsoft.com> #### Why I did it `subprocess` is used with `shell=True`, which is very dangerous for shell injection. #### How I did it remove `shell=True`, use `shell=False` #### How to verify it Pass UT
…ue (sonic-net#12534) Signed-off-by: maipbui <maibui@microsoft.com> #### Why I did it `subprocess.Popen()` and `subprocess.run()` is used with `shell=True`, which is very dangerous for shell injection. `os` - not secure against maliciously constructed input and dangerous if used to evaluate dynamic content #### How I did it Replace `os` by `subprocess`, remove `shell=True` #### How to verify it Passed UT Tested in DUT
…eam patches (sonic-net#12428) * Added ENV vars for non-upstream patches Signed-off-by: Vivek Reddy <vkarri@nvidia.com> * Made MLNX_PATCH_LOC an absolute path Signed-off-by: Vivek Reddy <vkarri@nvidia.com> * Added non-upstream-patches dir Signed-off-by: Vivek Reddy <vkarri@nvidia.com> * Update README.md * Addressed comments * Env vars updated Signed-off-by: Vivek Reddy <vkarri@nvidia.com> * Readme updated Signed-off-by: Vivek Reddy <vkarri@nvidia.com> Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
* [openssh]: Restore behavior of ClientAliveCountMax=0 OpenSSH 8.2 changed the behavior of ClientAliveCountMax=0 such that setting it to 0 disables connection-killing entirely when the connection is idle. Revert that change. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Remove build-dep command that should not be there Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
#### Why I did it Currently at the Azure build system, the P4RT container is disabled by default at the build time. Here the goal is to include the P4RT container at the build time while disabling it at the runtime. The user can enable/disable the p4rt app through the config based on the preference. #### How I did it Changed the config in rules/config and init-cfg.json.j2
…12416) Changes: -- Change name-space from Azure to sonic-net. -- Sort yang list in setup.py for yang-models list. #### Why I did it Sonic repo has moved to Linux-foundation. #### How I did it [yang-models]: Change name-space from Azure to sonic-net. #### How to verify it PR Tests are good enough to verify.
…-net#12190) Send remote address in TACACS+ authorization message. #### Why I did it TACACS+ authorization message not send remote address to server side. #### How I did it Send remote address in TACACS+ authorization message. #### How to verify it Pass all E2E test. Create new test case to validate remote address been send to server side. #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 - [ ] 202205 #### Description for the changelog Send remote address in TACACS+ authorization message. #### Ensure to add label/tag for the feature raised. example - [PR#2174](sonic-net/sonic-utilities#2174) where, Generic Config and Update feature has been labelled as GCU. #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
…#12073)" (sonic-net#12568) Why I did it This changes should go with updated SDE for BFN. Without update we do see orchagent core dump. How I did it Revert changes How to verify it Deploy topology. No core dump appears
* Fix kube mode to local mode long duration issue * Remove IPV6 parameters which is not necessary * Fix read node labels bug * Tag the running image to latest if it's stable * Disable image_version_higher check * Change image_version_higher checker test case Signed-off-by: Yun Li <yunli1@microsoft.com>
Signed-off-by: maipbui <maibui@microsoft.com> #### Why I did it `subprocess` is used with `shell=True`, which is very dangerous for shell injection. #### How I did it remove `shell=True`, use `shell=False` #### How to verify it Pass UT Manual test
…thorization. (sonic-net#12447) Export remote address to environment variable for TACACS authorization. #### Why I did it When remote user login, nss-tacplus need user remove address for TACACSS authorization. #### How I did it Export remote address to environment variable "SSH_REMOTE_IP" #### How to verify it Pass all E2E test. #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 - [ ] 202205 #### Description for the changelog Export remote address to environment variable for TACACS authorization. #### Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
* Add lossy scheduler for queue 7
#### Why I did it Submodule update for sonic-swss-common with following change: ``` 276f47c [sonic-db-cli] Fix sonic-db-cli crash when database config file not ready issue. (sonic-net#639) ``` #### How I did it #### How to verify it #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 #### Description for the changelog Submodule update for sonic-swss-common with following change: 276f47c [sonic-db-cli] Fix sonic-db-cli crash when database config file not ready issue. (sonic-net#639) #### A picture of a cute animal (not mandatory but encouraged)
Why I did it [ci] Upload the debian packages
… reboot in belgite platform (sonic-net#12322) Why I did it SONiC will report the kernel dump while system reboot in Belgite platform as the following shows: How I did it Cause: Invalid cdev container pointer from the inode is being accessing in misc device open, which causes a memory corruption in the slub. Because of the slub corruption, random crash is seen during reboot. Fix: - Instead of cdev pointer from the inode, mdev container pointer is used from the file->privdate_data member. Action: update the pddf_custom_wdt driver, How to verify it Do the reboot stress test to check whether there is kernel dump during reboot progress
Signed-off-by: maipbui <maibui@microsoft.com> #### Why I did it `subprocess` is used with `shell=True`, which is very dangerous for shell injection. #### How I did it remove `shell=True`, use `shell=False` #### How to verify it Manual test Pass UT
) Signed-off-by: maipbui <maibui@microsoft.com> #### Why I did it `subprocess` is used with `shell=True`, which is very dangerous for shell injection. `os` - not secure against maliciously constructed input and dangerous if used to evaluate dynamic content #### How I did it remove `shell=True`, use `shell=False` Replace `os` by `subprocess`
…emove subprocess with shell=True (sonic-net#12533)" (sonic-net#12616) This reverts commit 934871c. Unblocking sync from github to internal
Why I did it [Build] Fix the docker-sync not found issue How I did it When SONIC_CONFIG_USE_NATIVE_DOCKERD_FOR_BUILD not enabled, not to remove the docker-sync tag.
* Fix code irregular issues Signed-off-by: Yun Li <yunli1@microsoft.com>
Add dualtor test using TestbedV2 in buildimage repo. Why I did it Add dualtor test using TestbedV2 in buildimage repo. How I did it Add dualtor test using TestbedV2 in buildimage repo. Signed-off-by: Yutong Zhang <yutongzhang@microsoft.com>
* support sai-ptf-v2 in libsaithrift vs * add build target docker-ptf-sai syncd-rpcv2 and saiserverv2 Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add docker ptf sai Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add build condition for broadcom Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add docker syncd dbg and add debug symbol to docker-saiserverv2 Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * correct the build option * change the azure pipeline build template Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * change build option for docker-ptf-sai * enable ptf-sai docker build * remove the build for syncd-rpcv2 Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * fix issue in build tempalte * ignore useless package build when build sai-ptf Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * remove scapy version contraint Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * remove duplicated target docker-ptf Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * change template for testing the pipeline Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * remove duplicated target Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * fix error in make script Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add shel to setup env Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * replace with certain platform name Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * disable cache for syncd-rpcv2 Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * test without cache Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * disable cache Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * testing: disable the cache for build syncd-rpcv2 Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add cache back and get the code ready for testing Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * refactor code Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add workaround for issue in rules/sairedis.dep Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * refactor code Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
Why I did it In case the device contains more then one FAN drawer, the FANs name was incorrect. How I did it Passed max fan value to FAN object. Fixed get_name() FAN API How to verify it show platform fan
…ue (sonic-net#11985) Signed-off-by: maipbui <maibui@microsoft.com> #### Why I did it `subprocess.Popen()` and `subprocess.run()` is used with `shell=True`, which is very dangerous for shell injection. `os` - not secure against maliciously constructed input and dangerous if used to evaluate dynamic content #### How I did it Replace `os` by `subprocess` Remove unused functions
…-net#12554) Added YANG models for additional events for host, swss, and dhcp relay
Add event_publish code or regex for rsyslog plugin for additional events
Typo in prior PR sonic-net#11919 hardcodes Vlan name. Change command to use the $vlan variable instead Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
…12615) Why I did it Fixes sonic-net#12614 How I did it In the container_checker the database_chassis is added to expected container if device is supervisor To detect the device is superviso, add supervisor=1 to the platform_env.conf of 7808 sup platform How to verify it run container_checker monit check Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
686b9b1 Update Makefile to provision the ability of building with non-upstream patches (sonic-net#296) 3b95205 [patch]: Introduce sysctl param `arp_evict_no_carrier` (sonic-net#293) Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
…le (sonic-net#12602) - Why I did it Update SN2201 dynamic minimum fan speed table according to data provided by the thermal team. - How I did it Update the thermal table in device_data.py - How to verify it Run platform related regression Signed-off-by: Kebo Liu <kebol@nvidia.com>
…onic-net#12599) - Why I did it Fix logrotate firstaction script to reflect correct size. The size was modified to change dynamically based on disk size. However this variable was not updated sonic-net#9504 - How I did it Updated the variable based on disk size - How to verify it Verify in the generated rsyslog file if the variable is correctly generated from jinja template
sonic-host-services submodule update with following changes 6eac2d3 Merge pull request #19 from judyjoseph/macsec_feature_enable 31c6108 Sync has_per_asic_scope attribute to config_db in all namespaces for multi-asic 185547f Add UT to improve coverage, for namespace config update 7c3aca0 macsec_supported info is part of DEVICE_RUNTIME_METADATA itself.
sonic-net#11998) * Use the macsec_enabled flag in platform to enable macesc feature state * Add macsec supported metadata in DEVICE_RUNTIME_METADATA
[sonic-linkmgrd][master] submodule update b3501d2 Jing Zhang Wed Nov 2 22:22:45 2022 -0700 [active-standby][active-active] update link prober stats updating frequency to 30s (#152) 5d546ec Jing Zhang Tue Nov 1 16:12:17 2022 -0700 [202205] incrementing icmp buffer size (#150) 76b128a Jing Zhang Tue Nov 1 12:06:21 2022 -0700 [Active-Active] periodically re-sync soc side admin forwarding state (#151) sign-off: Jing Zhang zhangjing@microsoft.com
…-net#12627) add platform.json separately for LC6 that has different name, bc of supporting macsec Signed-off-by: Wenyi Zhang <wenyizhang@microsoft.com>
Why I did it Unify the Debian mirror sources Make easy to upgrade to the next Debian release, not source url code change required. Support to customize the Debian mirror sources during the build Relative issue: sonic-net#12523
…', or missing. (sonic-net#12588) bgpd.main.conf.j2: bugfix-9739 * Update bgpd.main.conf.j2 to gracefully handle the bgp configuration cases for when 'bgp_asn' is set to 'None', 'Null', or missing. How I did it Include a conditional statement to avoid configuring bgp in FRR when 'bgp_asn' is missing or set to 'None' or 'Null' How to verify it Configure 'bgp_asn' as 'None', 'Null' or have it missing from configurations and verify that /etc/frr/bgpd.conf does not have invalid bgp configurations like 'router bgp None' Description for the changelog Update bgpd.main.conf.j2 to gracefully handle the bgp configuration cases for when 'bgp_asn' is set to 'None', 'Null', or missing for bugfix 9739. Signed-off-by: cchoate54@gmail.com
* Build docker-gbsyncd-broncos image * Correct typo in LIBSAI_BRONCOS_URL_PREFIX * Update docker-gbsyncd-broncos/Dockerfile.j2 * Enable debug shell support on docker-gbsyncd-broncos * Include bcmsh in docker-gbsyncd-broncos Why I did it In docker-gbsyncd-broncos image, enable debug shell support for BRCM broncos PHY. How I did it How to verify it Note: need enable attr SAI_SWITCH_ATTR_SWITCH_SHELL_ENABLE support in BCM PAI library # bcmsh Press Enter to show prompt. Press Ctrl+C to exit. NOTICE: Only one bcmsh or bcmcmd can connect to the shell at same time. BRCM:> help help List of available commands - h or help => Print command menu - l => Print list of active ports on the PHY - ps <port_id> <options> => Print port status <options> => 1 -> Link status => 2 -> Link training failure status => 3 -> Link training RX status => 4 -> PRBS lock status => 5 -> PRBS lock loss status - rd <port_id> <addr> <no of registers to read> => Read register contents - wr <port_id> <addr> <data> => Write register data - rrd <lanemap> <if_side> <addr> <no of registers to read> => Raw read register contents using lanemap and if_side (line = 0, system = 1) - rwr <lanemap> <if_side> <addr> <data> => Raw write register data using lanemap and if_side (line = 0, system = 1) - fw or firmware => Print firmware version of the PHY - pd or port_dump <port_id> <flags> => Dump port status - eyescan <port_id> => Display eye scan - fec_status <port_id> => Get fec status of the port - polarity <lanemap> <if_side> <TX polarity> <RX Polarity> => Set TX and RX polarity <lanemap> => 0xF, 0xFF, or 0xFFFF based on number of lanes <if_side > => Line = 0, System = 1 <TX/RX Polarity> =>_TX/RX Polarity bitmap of all lanes Each bit represents a lane number. E.g. Lane 0's polarity value (0 or 1) is populated in Bit 0. - polarity <lanemap> <if_side> => Print TX and RX polarity - lb <port_id> <lb_value> => Enable loopback on the port lb_value = 0 -> Disable, 1 -> PHY, 2 -> MAC - lb <port_id> => Print loopback configuration of the port - prbs <port_id> <options> <val> => Set/Get PRBS configuration <options> => 1 -> Get PRBS state and polynomial 2 -> Set PRBS Polynomial, <val> - PRBS Polynomial Please refer to phy/chip documentation for valid values 3 -> Enable PRBS <val> => 0 Disable PRBS 1 Enable both PRBS Transmitter and Receiver 2 Enable PRBS Receiver 3 Enable PRBS Transmitter exit or q => Exit the diagnostic shell
Why I did it DX010 platform has limited routing table size. How I did it Enabling LPM. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Why I did it nameserver and domain entries from build system fsroot gets into sonic image. How I did it Clear /etc/resolv.conf before building image How to verify it Built image with it and verified with install that /etc/resolv.conf is empty
Why I did it syseepromd in pmon crashes because of missing import in python script and doesn't get in running state How I did it Fix missing import issue to avoid python script failing How to verify it Boot system and wait till syseepromd gets into running state Which release branch to backport (provide reason below if selected) 201811 201911 202006 202012 202106 202111 202205
…c-net#12648) Why I did it DHCP relay feature needs to be enabled for BmcMgmtToRRouter by default How I did it Update device type list
…et#12651) Migrate t0-sonic test jobs to TestbedV2. Why I did it Migrate t0-sonic test jobs to TestbedV2. How I did it Add two parameters to create testplan. Modify azure-pipelines.yml to run t0-sonic on tbv2. Signed-off-by: Yutong Zhang <yutongzhang@microsoft.com>
Advance sonic-swss submodule to pick up new commits: dbdf31c [counters] Improve performance by polling only configured ports buffer queue/pg counters sonic-net/sonic-swss#2473 ab4f804 [portsorch] remove port OID from saiOidToAlias map on port deletion sonic-net/sonic-swss#2483 ab29920 [QoS] Support dynamic headroom calculation for Barefoot platforms sonic-net/sonic-swss#2412 15beee4 Add support for voq counters in portsorch. sonic-net/sonic-swss#2467 c8d4905 [vlanmgr] Disable arp_evict_nocarrier for vlan host intf sonic-net/sonic-swss#2469 31c9321 [chassis][voq]Collect counters for fabric links sonic-net/sonic-swss#1944 Signed-off-by: Kebo Liu <kebol@nvidia.com>
sonic-net#12639) * Advance submodule sonic-utilities d5a6da31 Do not configure physical attributes on port channels in portconfig (sonic-net#2456) 48ee7722 Change db_migrator major version on master branch from version 3 to 4 (sonic-net#2470) f3746163 [GCU] Fix JsonPointerFilter bug (sonic-net#2477) 58dbb3e6 YANG Validation for ConfigDB Updates: TACPLUS, TACPLUS_SERVER, AAA, VLAN_SUB_INTERFACE tables + decorated validated_mod_entry (sonic-net#2452) 062f18a0 fix show interface neighbor expected empty issue (sonic-net#2465) 569edf3b Fix display disorder problem of show mirror_session (sonic-net#2447) daaf0ffc Disable "tag as local" when reboot (sonic-net#2451) 6621120b Fix sudo sfputil show error-status on a multiasic platform issue (sonic-net#2373) e8b1dcdf Add IP remove warnings for VRF commands (sonic-net#2351) 40cc8e11 [scripts/generate_dump] add information to tech-support file (sonic-net#2357) 8473517e Revert "[config reload]: On dual ToR systems, cache ARP and FDB table (sonic-net#2460) Signed-off-by: Stephen Sun <stephens@nvidia.com> * Advance sonic-platform-common aa86083 Fix issue: rounding float value for txpower and rxpower (sonic-net#320) 2052a63 Fix issue: copper cable should not display DOM information (sonic-net#318) cf4c6af CmisApi::get_application_advertisement catch AttributeError as well (sonic-net#316) Signed-off-by: Stephen Sun <stephens@nvidia.com> Signed-off-by: Stephen Sun <stephens@nvidia.com>
…-net#12668) Migrate multi-asic test jobs to TestbedV2. Why I did it Migrate multi-asic test jobs to TestbedV2. How I did it Add one parameter num_asic to create testplan. Modify azure-pipelines.yml to run multi-asic on tbv2. Signed-off-by: Yutong Zhang <yutongzhang@microsoft.com>
keboliu
approved these changes
Nov 11, 2022
Junchao-Mellanox
force-pushed
the
sn5600-api
branch
from
November 11, 2022 05:45
1a34791
to
db5a481
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add new thermal sensors for SN5600
How I did it
Add new thermal sensors for SN5600
How to verify it
Manual test
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)