-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slideshow: Update mobile styles #12204
Conversation
* Hide next/prev and mobile + add max-height to caption * Update caption max-height if autoplay enabled * Make sure slides on focus (touch slide) don't display an outline
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: May 7, 2019. |
thomasguillot, Your synced wpcom patch D27615-code has been updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well for me. 👍
@davidakennedy for the accessibility question... |
On mobile, swiping would be the natural form of interaction anyway. The arrows are primarily meant as shortcut for environments where pointing devices are the norm—even though you can swipe with the mouse it's unusual behavior. Because of this, I don't think this qualifies as an accessibility concern, but @davidakennedy will have a more sophisticated POV. |
Holding pending the question. Marking as "needs review" for now. |
I think these changes are okay. From an accessibility perspective, they still have the pagination buttons there to help them navigate around. Although, I like the arrow buttons better because they have a larger hit target. Some customers may have no vision or low vision, so seeing what's there (to be able to swipe it) could be a problem. So screen reader users need some controls to let them know what's there, and to navigate. This does bring up a larger issue, we're assuming all screen sixes less than 600px are touch screen. Is that a safe assumption? I think probably – I'm just raising it. |
* Kick off the changelog * Add 7.3.1 * Update date and post link * changelog: add #12219 * changelog: add #12170 * changelog: add #12184 * Changelog: add #12268 * Changelog: add #12081 * Changelog: add #12323 * Changelog: add #12204 * Changelog: add #12269 * Changelog: add #12332 * changelog: add #12339 * changelog: add #12209 * Changelog: add #12319 * Changelog: add #12357 * Changelog: add #12124 * Changelog: add #12373 * Changelog: add #12252 * Changelog: add #12383 * Changelog: add #12372 * changelog: add #12337 * Changelog: add #12290 * Changelog: add #12301 * Changelog: add #12061 * Testing list: add instructions for #12061 * Changelog: add #12393 * Update minimum supported version See #12287 * Changelog: add #12406 * Testing list: add #12406 * Changelog: add #12277 * Changelog: add #12412 * Changelog: add #11318 * Changelog: add #12328 * Changelog: add #12425 * Changelog: add #12380 * Changelog: add #12428 * Changelog: add #12414 * Changelog: add #12395 * Changelog & Testing list: add #12416, #12417, #12418, and #12348 * changelog: add #12379 * Changelog: add #12341 * changelog: add #12444 * Changelog: add #12434 * Changelog: add #12454 * Changelog: add #12460 * Changelog: add #12463 * Changelog: add #12457 * Changelog / testing list: add #10333 * Changelog: add #12467 Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Optimise the mobile styles of the Slideshow Block and make sure we don't display unnecessary elements (prev/next arrow) on small screens.
Changes proposed in this Pull Request:
Testing instructions:
Before:
After:
Proposed changelog entry for your changes: