Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Fix PHPCS translate errors #12332

Merged
merged 1 commit into from
May 10, 2019
Merged

CLI: Fix PHPCS translate errors #12332

merged 1 commit into from
May 10, 2019

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented May 10, 2019

This PR is a follow-up to #12015 and fixes all the PHPCS errors that were introduced in it, plus the ones that were existing in the Jetpack CLI class. As suggested by @akirk in #12015 (comment)

Changes proposed in this Pull Request:

  • Fix all the i18n-related warnings in the Jetpack CLI class.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

No, this is a cleanup PR.

Testing instructions:

  • Run phpcs on the file and verify there are no translation related errors in class.jetpack-cli.php.

Proposed changelog entry for your changes:

  • Fix all the translation-related phpcs errors in Jetpack CLI.

@tyxla tyxla added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Feature] Jetpack CLI [Focus] i18n Internationalization / i18n, adaptation to different languages [Type] Janitorial labels May 10, 2019
@tyxla tyxla requested review from akirk and a team May 10, 2019 10:29
@tyxla tyxla self-assigned this May 10, 2019
@tyxla tyxla mentioned this pull request May 10, 2019
Merged
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: May 14, 2019.
Scheduled code freeze: May 7, 2019

Generated by 🚫 dangerJS against b174c00

@akirk akirk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels May 10, 2019
@akirk
Copy link
Member

akirk commented May 10, 2019

Fantastic, thanks!

@tyxla tyxla added this to the 7.4 milestone May 10, 2019
akirk
akirk approved these changes May 10, 2019
View reviewed changes
Copy link
Member

@akirk akirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, also thanks for removing the translate call around the variable.

jeherve
jeherve approved these changes May 10, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@jeherve jeherve merged commit 121639c into master May 10, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels May 10, 2019
@jeherve jeherve deleted the fix/cli-phpcs-translate-errors branch May 10, 2019 10:37
jeherve added a commit that referenced this pull request May 17, 2019
@jeherve
Changelog: add #12332
43582ae
jeherve added a commit that referenced this pull request May 23, 2019
@jeherve
Changelog: add #12332
eec8787
jeherve added a commit that referenced this pull request May 27, 2019
@kraftbj @jeherve
7.4 Changelog (#12304)
0fb4436 
* Kick off the changelog

* Add 7.3.1

* Update date and post link

* changelog: add #12219

* changelog: add #12170

* changelog: add #12184

* Changelog: add #12268

* Changelog: add #12081

* Changelog: add #12323

* Changelog: add #12204

* Changelog: add #12269

* Changelog: add #12332

* changelog: add #12339

* changelog: add #12209

* Changelog: add #12319

* Changelog: add #12357

* Changelog: add #12124

* Changelog: add #12373

* Changelog: add #12252

* Changelog: add #12383

* Changelog: add #12372

* changelog: add #12337

* Changelog: add #12290

* Changelog: add #12301

* Changelog: add #12061

* Testing list: add instructions for #12061

* Changelog: add #12393

* Update minimum supported version

See #12287

* Changelog: add #12406

* Testing list: add #12406

* Changelog: add #12277

* Changelog: add #12412

* Changelog: add #11318

* Changelog: add #12328

* Changelog: add #12425

* Changelog: add #12380

* Changelog: add #12428

* Changelog: add #12414

* Changelog: add #12395

* Changelog & Testing list: add #12416, #12417, #12418, and #12348

* changelog: add #12379

* Changelog: add #12341

* changelog: add #12444

* Changelog: add #12434

* Changelog: add #12454

* Changelog: add #12460

* Changelog: add #12463

* Changelog: add #12457

* Changelog / testing list: add #10333

* Changelog: add #12467


Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akirk akirk akirk approved these changes

@jeherve jeherve jeherve approved these changes

Assignees

@tyxla tyxla

Labels
[Feature] Jetpack CLI [Focus] i18n Internationalization / i18n, adaptation to different languages [Type] Janitorial
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.
5 participants
@tyxla @jetpackbot @akirk @jeherve @matticbot