Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Remove pre-5.1 era code #12287

Merged
merged 2 commits into from
May 15, 2019
Merged

General: Remove pre-5.1 era code #12287

merged 2 commits into from
May 15, 2019

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented May 7, 2019

A quick first pass at removing code required for WP 5.0 compatibility as WP 5.2 is slated to ship today (making our minimum 5.1).

A couple references for 5.1 removal were for features that, in the end, didn't land in 5.1, so bumping them to 5.2 which landed them.

Changes proposed in this Pull Request:

  • Remove legacy code.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • Janitorial, not a new feature.

Testing instructions:

  • Run unit tests, related posts, and plugin search hints.

Proposed changelog entry for your changes:

  • n/a

@kraftbj kraftbj added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Janitorial labels May 7, 2019
@kraftbj kraftbj requested review from a team as code owners May 7, 2019 15:38
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello kraftbj! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D27920-code before merging this PR. Thank you!

@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: June 4, 2019.
Scheduled code freeze: May 28, 2019

Generated by 🚫 dangerJS against 613353b

@kraftbj kraftbj added [Status] In Progress [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Status] In Progress labels May 7, 2019
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels May 15, 2019
@jeherve jeherve added this to the 7.4 milestone May 15, 2019
@kraftbj kraftbj merged commit 72afe97 into master May 15, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels May 15, 2019
@kraftbj kraftbj deleted the bump/wp-min-5.1 branch May 15, 2019 15:08
jeherve added a commit that referenced this pull request May 17, 2019
kraftbj added a commit that referenced this pull request May 21, 2019
kraftbj added a commit that referenced this pull request May 21, 2019
* Bump minimum WP version missed in #12287

* Update minimum version missed in #12395
jeherve added a commit that referenced this pull request May 23, 2019
jeherve added a commit that referenced this pull request May 27, 2019
* Kick off the changelog

* Add 7.3.1

* Update date and post link

* changelog: add #12219

* changelog: add #12170

* changelog: add #12184

* Changelog: add #12268

* Changelog: add #12081

* Changelog: add #12323

* Changelog: add #12204

* Changelog: add #12269

* Changelog: add #12332

* changelog: add #12339

* changelog: add #12209

* Changelog: add #12319

* Changelog: add #12357

* Changelog: add #12124

* Changelog: add #12373

* Changelog: add #12252

* Changelog: add #12383

* Changelog: add #12372

* changelog: add #12337

* Changelog: add #12290

* Changelog: add #12301

* Changelog: add #12061

* Testing list: add instructions for #12061

* Changelog: add #12393

* Update minimum supported version

See #12287

* Changelog: add #12406

* Testing list: add #12406

* Changelog: add #12277

* Changelog: add #12412

* Changelog: add #11318

* Changelog: add #12328

* Changelog: add #12425

* Changelog: add #12380

* Changelog: add #12428

* Changelog: add #12414

* Changelog: add #12395

* Changelog & Testing list: add #12416, #12417, #12418, and #12348

* changelog: add #12379

* Changelog: add #12341

* changelog: add #12444

* Changelog: add #12434

* Changelog: add #12454

* Changelog: add #12460

* Changelog: add #12463

* Changelog: add #12457

* Changelog / testing list: add #10333

* Changelog: add #12467


Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants