-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Business Hours: Update front-end of the description list #12393
Conversation
* Make sure parent element clears floats * Have the terms and descriptions on the same line * Terms elements should be bold to differenciate them from the descriptions * Overwrite description's default margin * Add small right margin to terms
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: June 4, 2019. |
Since you are adding new files, after you merge this PR you will need to add the new files to the diff manually to get the tests to pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does look better imo. 👍 This should be good to merge once it's design approved.
Much nicer without all that extraneous whitespace. Can you remove the repetitious "From" as well? |
I can have a look at the "From ... to ..." but probably in a different PR as it touches a different portion of the code |
In this case this should be good to merge. I've unblocked the PR so you should be able to merge, but as I mentioned above, you'll need a bit of manual work to port your changes over to WordPress.com in D28309-code this time:
|
Thank you @jeherve |
* Kick off the changelog * Add 7.3.1 * Update date and post link * changelog: add #12219 * changelog: add #12170 * changelog: add #12184 * Changelog: add #12268 * Changelog: add #12081 * Changelog: add #12323 * Changelog: add #12204 * Changelog: add #12269 * Changelog: add #12332 * changelog: add #12339 * changelog: add #12209 * Changelog: add #12319 * Changelog: add #12357 * Changelog: add #12124 * Changelog: add #12373 * Changelog: add #12252 * Changelog: add #12383 * Changelog: add #12372 * changelog: add #12337 * Changelog: add #12290 * Changelog: add #12301 * Changelog: add #12061 * Testing list: add instructions for #12061 * Changelog: add #12393 * Update minimum supported version See #12287 * Changelog: add #12406 * Testing list: add #12406 * Changelog: add #12277 * Changelog: add #12412 * Changelog: add #11318 * Changelog: add #12328 * Changelog: add #12425 * Changelog: add #12380 * Changelog: add #12428 * Changelog: add #12414 * Changelog: add #12395 * Changelog & Testing list: add #12416, #12417, #12418, and #12348 * changelog: add #12379 * Changelog: add #12341 * changelog: add #12444 * Changelog: add #12434 * Changelog: add #12454 * Changelog: add #12460 * Changelog: add #12463 * Changelog: add #12457 * Changelog / testing list: add #10333 * Changelog: add #12467 Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Reduce the size taken by the Business Hours on a page.
Changes proposed in this Pull Request:
Testing instructions:
Before:
Twenty Nineteen / Shoreditch
After:
Twenty Nineteen / Shoreditch
Proposed changelog entry for your changes: