-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn in log if user's WP version is too old for Jetpack #12341
Conversation
This is an automated check which relies on |
I think this would be pretty noisy running on every load, but this is a situation that generally only folks like us would find ourselves in. WordPress itself won't let users update to versions of Jetpack that are indicated by us as needing a newer version of WordPress, so this would only be hit by folks updating Jetpack in weird ways. Until recently we didn't return out at all until some of us developers fataled out when manually installing Jetpack on WP 4.9. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick suggestion to avoid flooding too many error logs, and to ensure the message will be translatable.
This should avoid flooding folks' error logs; we'll only log it if Debugging mode is on. See #12341 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be good to merge now that we are a bit more conservative, imo.
@kraftbj I'll let you merge if you are happy with this too.
* Kick off the changelog * Add 7.3.1 * Update date and post link * changelog: add #12219 * changelog: add #12170 * changelog: add #12184 * Changelog: add #12268 * Changelog: add #12081 * Changelog: add #12323 * Changelog: add #12204 * Changelog: add #12269 * Changelog: add #12332 * changelog: add #12339 * changelog: add #12209 * Changelog: add #12319 * Changelog: add #12357 * Changelog: add #12124 * Changelog: add #12373 * Changelog: add #12252 * Changelog: add #12383 * Changelog: add #12372 * changelog: add #12337 * Changelog: add #12290 * Changelog: add #12301 * Changelog: add #12061 * Testing list: add instructions for #12061 * Changelog: add #12393 * Update minimum supported version See #12287 * Changelog: add #12406 * Testing list: add #12406 * Changelog: add #12277 * Changelog: add #12412 * Changelog: add #11318 * Changelog: add #12328 * Changelog: add #12425 * Changelog: add #12380 * Changelog: add #12428 * Changelog: add #12414 * Changelog: add #12395 * Changelog & Testing list: add #12416, #12417, #12418, and #12348 * changelog: add #12379 * Changelog: add #12341 * changelog: add #12444 * Changelog: add #12434 * Changelog: add #12454 * Changelog: add #12460 * Changelog: add #12463 * Changelog: add #12457 * Changelog / testing list: add #10333 * Changelog: add #12467 Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
When I was testing another PR on VVV, the tests would fail with "class Jetpack not found" errors. It turns out that this was because I had an old (5.0-alpha) source tree in my VM, and there's an early return in jetpack.php if it detects an incompatible WordPress version.
My hope is that this change won't result in crazy verbose logging on sites with old versions of Jetpack, but... those sites are running an incompatible WordPress version anyway, so if it wasn't this weirdness it would be other weirdness. It also might be helpful in case they're missing the notices in their wp-admin.
Changes proposed in this Pull Request: