-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General: require PHP 5.3+ to be able to run Jetpack. #12395
Conversation
If a site runs WP 5.1 (where the PHP requirements are still PHP 5.2) and updates Jetpack: 1. We pause Jetpack (stop loading it). 2. We display an admin notice inviting folks to update PHP. 3. If WP_DEBUG is on, we log an error.
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: June 4, 2019. |
@@ -29,12 +29,6 @@ env: | |||
# so it doesn't need to be re-defined below. | |||
matrix: | |||
include: | |||
# The versions listed below run within Precise distro with PHP 5.2 due to Travis limitation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love these red lines :)
❤️ |
* | ||
* @since 7.4.0 | ||
*/ | ||
function jetpack_admin_unsupported_php_notice() { ?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could moved this inside the if ( version_compare( phpversion(), JETPACK__MINIMUM_PHP_VERSION, '<' ) ) {
?
* Kick off the changelog * Add 7.3.1 * Update date and post link * changelog: add #12219 * changelog: add #12170 * changelog: add #12184 * Changelog: add #12268 * Changelog: add #12081 * Changelog: add #12323 * Changelog: add #12204 * Changelog: add #12269 * Changelog: add #12332 * changelog: add #12339 * changelog: add #12209 * Changelog: add #12319 * Changelog: add #12357 * Changelog: add #12124 * Changelog: add #12373 * Changelog: add #12252 * Changelog: add #12383 * Changelog: add #12372 * changelog: add #12337 * Changelog: add #12290 * Changelog: add #12301 * Changelog: add #12061 * Testing list: add instructions for #12061 * Changelog: add #12393 * Update minimum supported version See #12287 * Changelog: add #12406 * Testing list: add #12406 * Changelog: add #12277 * Changelog: add #12412 * Changelog: add #11318 * Changelog: add #12328 * Changelog: add #12425 * Changelog: add #12380 * Changelog: add #12428 * Changelog: add #12414 * Changelog: add #12395 * Changelog & Testing list: add #12416, #12417, #12418, and #12348 * changelog: add #12379 * Changelog: add #12341 * changelog: add #12444 * Changelog: add #12434 * Changelog: add #12454 * Changelog: add #12460 * Changelog: add #12463 * Changelog: add #12457 * Changelog / testing list: add #10333 * Changelog: add #12467 Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Given that Jetpack supports WordPress’ latest version (currently 5.2) as well as one version prior, we can't benefit from the changes introduced in WordPress 5.2 yet: Jetpack currently supports WordPress 5.1, and the required PHP version set by WP 5.1 is PHP 5.2.
This PR aims to change that required PHP version for Jetpack, until WordPress 5.3 is released; at that point Jetpack can go back to following WordPress’ PHP requirements and thus require PHP 5.6.
Changes proposed in this Pull Request:
If a site runs WP 5.1 (where the PHP requirements are still PHP 5.2) and updates Jetpack:
WP_DEBUG
is on, we log an error.Is this a new feature or does it add/remove features to an existing part of Jetpack?
Testing instructions:
wp-config.php
file:define( 'JETPACK__MINIMUM_PHP_VERSION', '7.4' );
Proposed changelog entry for your changes: