Evmos stg #1
Merged
Evmos stg #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds and uses JSON conversion helpers for converting non-JSON datatypes (e.g. Date objects) in locking tests: - Add `Campaign`-specific `toJson` helper - Add `LockEventItem | UnlockEventItem | WithdrawEventItem`-specific `toJson` helper - Use the above in their respective tests
Migrates from static to dynamic mock data for the imitation transaction tests.
Changes Campaign.lastUpdated to optional.
Ensures that the mocked imitation transfers _always_ have a `value` above `0`: - Set a minimum value of >0 for transfers in imitation transaction tests
Adds GET /v1/locking/campaigns/:campaignId/leaderboard endpoint mapping.
…l#1560) Moves all Locking Service-related routes under `/community`, aligning with the domain of the Activity Program: - Rename `Locking-` module, controller, service to `Community-`. - Rename the following (as of yet unused) routes: - `GET` `/v1/locking/campaigns` ->`/v1/community/campaigns` - `GET` `/v1/locking/campaigns/:campaignId` ->`/v1/community/campaigns/:campaignId` - `GET` `/v1/locking/campaigns/:campaignId/leaderboard` -> `/v1/community/campaigns/:campaignId/leaderboard` - Rename the following (and deprecate with a redirection of the currently used) routes: - `GET` `/v1/locking/leaderboard` -> `/v1/community/locking/leaderboard` - `GET` `/v1/locking/leaderboard/rank/:safeAddress` -> `/v1/community/locking/:safeAddress/rank` - `GET` `/v1/locking/:safeAddress/history` -> `/v1/community/locking/:safeAddress/history`
Adds validation of the campaign retrieved by ID: - Add `CampaignSchema` parsing to `ILockingService['getCampaignById']` - Unskip relevant test
Renames "locking" domain to "community" - the folder and all related components within it: - `/src/domain/locking` -> `/src/domain/community` - `ILockingRepository`-> `ICommunityRepository` - `LockingRepository` -> `CommunityRepository` - `LockingDomainModule` -> `CommunityDomainModule`
Renames all instances of "rank" to be lock-specific: - `ILockingApi['getRank']` -> `ILockingApi['getLockingRank']` - `ICommunityRepository['getRank']` -> `ICommunityRepository['getLockingRank']` - `RankSchema` -> `LockingRankSchema` - `RankPageSchema` -> `LockingRankPageSchema` - `Rank` -> `LockingRank` - `RankPage` -> `LockingRankPage` - `rankBuilder` -> `lockRankBuilder`
updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
updated-dependencies: - dependency-name: "@safe-global/safe-deployments" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
updated-dependencies: - dependency-name: viem dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
updated-dependencies: - dependency-name: redis dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Aligns `ActivityMetadata` entity by removing `resourceId` and changing `maxPoints` to a number: - Remove `resourceId` and change `maxPoints` to number in `ActivityMetadataSchema` - Update `ActivityMetadata` to reflect changes - Update tests accordingly
Add ILockingApi['getCampaignRank']
Add ICommunityRespository['getCampaignRank'] and implementation Add CommunityController['getCampaignRank]` under aforementioned route
Change boost, points, and boostedPoints to numbers in CampaignRank.
Renames points to totalPoints and boostedPoints to totalBoostedPoints in CampaignRankSchema.
…lobal#1567) Checksums the incoming `safeAddress` of `BalancesController['getBalances']` and propagates the stricter (`0x${string}`) type throughout the project accordingly: - Add validation pipe checksum to incoming `safeAddress` of `BalancesController['getBalances']` - Update `safeAddress` argument of `BalancesService['getBalances | clearBalance']` - Update `safeAddress` argument type of `IBalancesRepository['getBalances | clearBalance']` and all implementor - Update `safeAddress` argument type of `IBalancesApi['getBalances']` and all implementors (Safe/Zerion) - Update `safeAddress` type of Safe/Zerion balance cache - Propagate type through getting Safe overviews, after checksumming address in `Caip10AddressesPipe` - Update types/tests accordingly
Moves locking entities from `/routes/locking` to `/routes/community` folder for consistency: - Move `/routes/locking/entities` to `/routes/community/entities` - Update imports accordingly
Removes "legacy" locking routes: - Remove `LockingController` (and test coverage) - Remove `LockingModule` (and registration)
Pivots from using `getAddress` to parsing against a designated schema for CAIP-10 addresses, also adding verification of the `chainId`: - Create `Caip10AddressPipeSchema` - Parse incoming CAIP-10 addresses against schema - Add test coverage
…obal#1566) Enables `@typescript-eslint/no-unsafe-enum-comparison` lint rule and addresses instances where "unsafe" enum comparison occurs: - Enable `@typescript-eslint/no-unsafe-enum-comparison` rule in `eslint.config.mjs` - Fix all "unsafe" enum comparison
Enables the `@typescript-eslint/require-await` line rule and addresses instances where unnecessary `async` is used: - Enable `@typescript-eslint/require-await` rule in `eslint.config.mjs` - Remove all unnecessary uses of `async` and associated changes
…`null` (safe-global#1584) Changes the validation of `MultisigTransaction['confirmationsRequired']` to also expect nullish values and default to `null` if no number is returned: - Change `MultisigTransactionSchema['confirmationsRequired']` to expect a number or nullish values, defaulting to `null` - Update instances where `confirmationsRequired` is references, falling back to the threshold of the Safe - Add relative test coverage
…1585) Changes the mock `appCode` value in "Gets Generic confirmation view if swap app is restricted" test of the `TransactionsViewController` tests to ensure it isn't the same as that of mocked `verifiedApp` value.
…tion is …" (safe-global#1586) Reverts safe-global#1584 This adjustment is no longer necessary as it solved what was later to be deemed indexing issues.
Bumps [eslint](https://github.com/eslint/eslint) from 9.5.0 to 9.7.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v9.5.0...v9.7.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.5.2 to 5.5.3. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml) - [Commits](microsoft/TypeScript@v5.5.2...v5.5.3) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [viem](https://github.com/wevm/viem) from 2.17.3 to 2.17.4. - [Release notes](https://github.com/wevm/viem/releases) - [Commits](https://github.com/wevm/viem/compare/viem@2.17.3...viem@2.17.4) --- updated-dependencies: - dependency-name: viem dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) from 7.15.0 to 7.16.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.16.1/packages/typescript-eslint) --- updated-dependencies: - dependency-name: typescript-eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Adds cache management to AccountDatasource, along with its associated tests.
…afe-global#1771) - Adds `dataTypeId` to `AccountDataSetting`. - Changes `UpsertAccountDataSettingDto.id` to `UpsertAccountDataSettingDto.dataTypeId`. - Both `AccountDataSetting.name` and `AccountDataSetting.description` were removed.
…e-global#1772) Rename `Account.accountId` to `Account.id` on the route-level `Account` entity.
Adds a new `IPushNotificationsApi` datasource, initially implemented by FIrebase (Cloud Messaging). ## Changes - Add new `IPushNotificationsApi` interface - Implement above interface in `FirebaseCloudMessagingApiService` - Add relative push notification configuration
Refactors `JwtService` to allow manually setting the issuer/secret when signing a token: - Expose the option to specify issuer/secret to `JwtClient`, otherwise defaulting to env. vars. in `JwtService` - Remove `options` that override claims on token, instead opting for their spec, e.g. `iat`, `nbf`, `exp` (instead of `issuedAt`, `notBefore`, `expiresIn`) - Accept/return dates for the all spec. specific dateclaims - Use `JwtService` in `FirebaseCloudMessagingApiService` instead of `jsonwebtoken` - Update tests accordingly
…l#1775) Removes `PUSH_NOTIFICATIONS_API_BASE_URI` from the environment variables checked at the service startup time, as a default value is provided on the `configuration.ts` file.
Add according test coverage for `FirebaseCloudMessagingApiService`.
Moves domain-considered logic from `CacheHooksService` to a new `HooksRepository` in the domain: - Move domain logic from `CacheHooksService` to `HooksRepository` - Propagate changes accordingly
Refactor route "cache-hooks" to be a more generic, also adding distinction between Transaction Service and Config. Service events: - Rename `cache-hooks` to `hook` and the associated controller, service(s) and module accordingly - Separate `EventType` into `TransactionEventType` and `ConfigEventType` and propagate changes
Adds `CounterfactualSafesDatasource`, database migration, and associated tests.
Bumps [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) from 3.1.0 to 3.2.0. - [Release notes](https://github.com/docker/setup-qemu-action/releases) - [Commits](docker/setup-qemu-action@v3.1.0...v3.2.0) --- updated-dependencies: - dependency-name: docker/setup-qemu-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ts-jest](https://github.com/kulshekhar/ts-jest) from 29.2.2 to 29.2.3. - [Release notes](https://github.com/kulshekhar/ts-jest/releases) - [Changelog](https://github.com/kulshekhar/ts-jest/blob/main/CHANGELOG.md) - [Commits](kulshekhar/ts-jest@v29.2.2...v29.2.3) --- updated-dependencies: - dependency-name: ts-jest dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [winston](https://github.com/winstonjs/winston) from 3.13.0 to 3.13.1. - [Release notes](https://github.com/winstonjs/winston/releases) - [Changelog](https://github.com/winstonjs/winston/blob/master/CHANGELOG.md) - [Commits](winstonjs/winston@v3.13.0...v3.13.1) --- updated-dependencies: - dependency-name: winston dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [husky](https://github.com/typicode/husky) from 9.0.11 to 9.1.1. - [Release notes](https://github.com/typicode/husky/releases) - [Commits](typicode/husky@v9.0.11...v9.1.1) --- updated-dependencies: - dependency-name: husky dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [semver](https://github.com/npm/node-semver) from 7.6.2 to 7.6.3. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v7.6.2...v7.6.3) --- updated-dependencies: - dependency-name: semver dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@nestjs/swagger](https://github.com/nestjs/swagger) from 7.3.1 to 7.4.0. - [Release notes](https://github.com/nestjs/swagger/releases) - [Changelog](https://github.com/nestjs/swagger/blob/master/.release-it.json) - [Commits](nestjs/swagger@7.3.1...7.4.0) --- updated-dependencies: - dependency-name: "@nestjs/swagger" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- Adds a feature flag to control Chain-related debugging logs: `configHooksDebugLogs`. - Adds optional logging to `ConfigApi` when the `clearChain` function is executed (after the reception of a `CHAIN_UPDATED` event). - Adds optional logging to `CacheFirstDatasource` when the `chain/chains` cache key is written in the cache.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.